This project is read-only.
1
Vote

v8::Isolate::New' : function does not take 0 arguments

description

..\V8.NET-Proxy\V8EngineProxy.cpp - line 71

Seems as if the last commit does not build, since the Isolate::New is expecting a Isolate::CreateParams parameter.
    if (!_V8Initialized) // (the API changed: https://groups.google.com/forum/#!topic/v8-users/wjMwflJkfso)
    {
        v8::V8::InitializePlatform(v8::platform::CreateDefaultPlatform());
        v8::V8::InitializeICU();
        v8::V8::Initialize();
        _V8Initialized = true;
    }

    _Isolate = Isolate::New();
Which one should be the default? maybe...
_Isolate = Isolate::New(Isolate::CreateParams());
I expect that this is related to a V8 update associated to the link in the comment?

comments

jamesnw wrote Oct 29, 2015 at 7:30 PM

Hi there. ;) Under the "Documentation" tab you'll find the "For Development" section. The version of the Google source used is there. The last commit of the master is ALWAYS a successful compile (and usually development also). I'll have to update from the Google source and see if anything has changed.

jamesnw wrote Apr 5 at 8:18 AM

The dev branch now compiles with the latest V8 (look for the V8Update.cmd file in the V8.NET\Source\V8.NET-Proxy\V8 directory, which may help with compiling the V8 source). I'll be making a new release soon.